Add edge-case tests, exclude pytest tmpdirs from ruff/git - #25
Merged
Conversation
Adds two tests for previously-uncovered error paths: - `leafpress ui` ImportError fallback when PyQt6 isn't installed - pipeline OSError branch when WeasyPrint is installed but its system libraries can't be loaded (cairo/pango missing) Also fixes a side issue: leftover pytest tmpdirs (`pytest-of-*/`, `leafpress-mermaid-*/`, `uv-*.lock`) were being picked up by `ruff check`, causing the lint step to fail on a fixture file containing intentionally-malformed TOML. Adds them to ruff's extend-exclude and to .gitignore so they no longer pollute the working tree or break linting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
leafpress uiImportError fallback when PyQt6 is not installed (asserts exit code 1, panel content, andleafpress[ui]install hint).leafpress doctor, and preserves the original error.pytest-of-*/,leafpress-mermaid-*/, anduv-*.lockto.gitignoreand to ruff'sextend-exclude. Stale pytest tmpdirs were causingruff checkto fail on an intentionally-malformed TOML fixture file.Test plan
uv run ruff checkuv run ruff format --checkuv run ty checkuv run pytest— 781 passed