Added google login new params with fix to facebook login#13
Open
DinithHerath wants to merge 4 commits into
Open
Added google login new params with fix to facebook login#13DinithHerath wants to merge 4 commits into
DinithHerath wants to merge 4 commits into
Conversation
huychau
reviewed
Mar 25, 2022
| first_name=user_data.get('first_name'), | ||
| last_name=user_data.get('last_name'), | ||
| ) | ||
| if (provider == FACEBOOK_PROVIDER): |
Owner
There was a problem hiding this comment.
@DinithHerath Many thanks for your update. I think we don't need to check the provider, the implementation like this:
user = User.objects.create(
username=user_data['email'],
email=user_data['email'],
first_name=user_data.get('first_name') or user_data.get('given_name'),
last_name=user_data.get('last_name') or user_data.get('family_name'),
)
Feel free to check and update, I will merge after that. Sorry for late response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to