Open
Conversation
dosubot
bot
added
size:S
United600
commented
Mar 27, 2026
| <Type Name="ProtoBuf.Serializers.ImmutableSortedDictionarySerializer`2" Activate="Required Public" /> | ||
| <Type Name="ProtoBuf.Serializers.ImmutableIDictionarySerializer`2" Activate="Required Public" /> | ||
| <Type Name="ProtoBuf.Serializers.ConcurrentBagSerializer`2" Activate="Required Public" /> | ||
| ...--> |
Collaborator
Author
There was a problem hiding this comment.
😩 I got tired of adding them individually. I'm not sure we'll see significant savings by continuing.
United600
commented
Mar 27, 2026
| <Type Name="ProtoBuf.Internal.Level300DefaultSerializer" Dynamic="Required All" /> | ||
| <Type Name="ProtoBuf.Internal.Level300FixedSerializer" Dynamic="Required All" /> | ||
|
|
||
| <Type Name="CommunityToolkit.Mvvm.Messaging.IMessengerExtensions" Dynamic="Required All" /> |
Collaborator
Author
There was a problem hiding this comment.
When the app launches, this method failed even though it is not marked with the RequiresDynamicCode attribute.
Maybe we could trim it more efficiently using the method troubleshooter, though I already attempted it without success.
Owner
|
Do we want to enable this before moving away from protobuf? |
Collaborator
Author
The gains extend beyond protobuf, but we can hold off for now and use it as test bed. The earlier we start trimming, the better prepared we'll be for NAOT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followed this blog post, and used this troubleshooter to enable .NET Native trimming.
Reduces the overall bundle size by approximately 10 MB.
And after unzipping, each package saves approximately 10 MB, with the
Screenbox.dllfile being the primary beneficiary of this reduction.