feat/option for auto-deleting archives once file is extracted#2156
Open
APimenta4 wants to merge 2 commits into
Open
feat/option for auto-deleting archives once file is extracted#2156APimenta4 wants to merge 2 commits into
APimenta4 wants to merge 2 commits into
Conversation
Signed-off-by: AFONSO PIMENTA <afonsocpimenta04@gmail.com>
Signed-off-by: AFONSO PIMENTA <afonsocpimenta04@gmail.com>
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Implements #2112
Adds a new
autoDeleteArchiveAfterExtractionuser setting (defaults to false to ensure no new surprise behavior is added) for automatically deleting the downloaded game's zipped filesI made a table that cover the new behavior for all setting scenarios. I included auto extract and per-download extraction settings as they also have an impact on the outcome
Note: wrapped the
deleteArchiveFilefunction in order to be able to be invoke the file deletion from the main process