feat(window-manager): implement in-app achievement notifications for …#2251
Open
Moyasee wants to merge 2 commits into
Open
feat(window-manager): implement in-app achievement notifications for …#2251Moyasee wants to merge 2 commits into
Moyasee wants to merge 2 commits into
Conversation
…Linux - Added `sendAchievementToFocusedWindow` method to handle achievement notifications within the app on Linux/Wayland, where standalone overlays are not supported. - Updated `mergeAchievements` to utilize the new method for in-app notifications. - Introduced IPC listener for in-app achievement notifications in the preload script. - Enhanced the renderer to display achievement notifications using the new overlay component. This update improves user experience by providing timely feedback on achievements directly within the application interface.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



…Linux
sendAchievementToFocusedWindowmethod to handle achievement notifications within the app on Linux/Wayland, where standalone overlays are not supported.mergeAchievementsto utilize the new method for in-app notifications.This update improves user experience by providing timely feedback on achievements directly within the application interface.
When submitting this pull request, I confirm the following (please check the boxes):
Fill in the PR content:
update for linux users
recent electron update killed the custom notification window which is causing it to spawn directly in the center and not on top of all apps
this PR fixes this issue doing the following: