Adding validation#2
Merged
Merged
Conversation
- Add required DataFrame column checks in all prepare_*_records() methods - Use Literal type hints for horizon_type, meteo_type, snow_type params - Add NaN guards before int() casts to prevent crashes on missing data - Surface server error details (JSON detail field) in SapphireAPIError - Add 12 error-path tests for missing columns, NaN handling, and error messages Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduce a dedicated validators module with input validation functions (URL, integers, enums, response truncation, safe int conversion) and constant sets for valid API parameters. Harden the base client with constructor validation, 429 retry support, response text truncation in exceptions, and a redirect limit. Add enum/skip/limit validation to all preprocessing and postprocessing read methods. Add pip-audit to CI and create SECURITY.md disclosure policy. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.