Skip to content

Add long-term forecast horizon support to skill metrics #4

Merged
mabesa merged 1 commit into
mainfrom
feature/preprocessing-gateway-integration
Mar 10, 2026
Merged

Add long-term forecast horizon support to skill metrics #4
mabesa merged 1 commit into
mainfrom
feature/preprocessing-gateway-integration

Conversation

@mabesa

@mabesa mabesa commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add VALID_SKILL_METRIC_HORIZONS constant as the union of VALID_HORIZONS and VALID_LONG_FORECAST_HORIZONS, enabling skill metrics to accept
    "quarter" and all long-term forecast horizons
  • Update read_skill_metrics() validation and prepare_skill_metric_records() Literal type to use the new set
  • Export VALID_SKILL_METRIC_HORIZONS from the package public API
  • Preprocessing and short-term clients remain unaffected

Test plan

  • 188 tests pass, 0 skipped
  • mypy passes with no issues
  • New tests verify "quarter" is accepted by skill metrics read/prepare
  • Regression guard: "quarter" is still rejected by preprocessing
  • Constant tests verify the union relationship between horizon sets

…s in skill metrics

Skill metrics now accept "quarter" (and any future long-term horizon) by
validating against VALID_HORIZONS | VALID_LONG_FORECAST_HORIZONS. Preprocessing
and short-term clients remain unaffected.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mabesa mabesa merged commit a196e17 into main Mar 10, 2026
3 checks passed
@mabesa mabesa deleted the feature/preprocessing-gateway-integration branch March 10, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant