Skip to content

Updated require statement #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhavin-vadgama wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated require statement #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/getBibCodeFromObject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ function fieldsAreOk(object) {
// ========== All fields are ok ['entryType', 'key', 'data'] ==========
// Now let's move to check for valid fields for any specific entry type
const entryType = object.entryType; // Checks entry type etc.
const bibtex = require('./BibTeX');

@koppor koppor Sep 24, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BibTeX should be spelled with captial X (see https://en.wikipedia.org/wiki/BibTeX). Thus, this fix seems to be a quick fix. Could you fix it in the other way so taht this require statement works?

const bibtex = require('./BibTex');
const bib = new bibtex();

const entryTypeFields = bib.getSpecificEntryTypeFields(entryType);
Expand Down Expand Up @@ -294,4 +294,4 @@ function fieldsAreOk(object) {
}
}
]
*/
*/