feat: sync with openiap v1.3.17#13
Conversation
📝 WalkthroughWalkthroughThis PR synchronizes the OpenIAP GDScript addon with OpenIAP v1.3.17/v1.3.28, adding support for Google Play Billing Library 5.0+ and 7.0+ features. Key changes include adding default values to existing IAP type fields, introducing new fields like Changes
Possibly related PRs
Poem
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @hyochan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Godot IAP plugin to align with OpenIAP v1.3.17, primarily focusing on enhancing Android billing capabilities. It introduces new data structures to support features from Google Play Billing Library 5.0+ and 7.0+, such as installment plans and pending purchase updates. These additions ensure the plugin remains compatible with the latest Android billing system advancements, providing more detailed information for in-app purchases and subscriptions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request syncs with OpenIAP v1.3.17, introducing new classes and fields to support recent features from Google Play Billing Library 5.0+ and 7.0+. The changes primarily affect the auto-generated types.gd file and include corresponding updates to documentation. The implementation is consistent with the existing codebase. I've provided a few suggestions to initialize member variables in the new data classes to improve robustness and prevent potential null-related issues.
- Update openiap-versions.json (gql: 1.3.17, apple: 1.3.14, google: 1.3.28) - Add InstallmentPlanDetailsAndroid class (Billing Library 7.0+) - Add PendingPurchaseUpdateAndroid class (Billing Library 5.0+) - Add purchase_option_id_android field to DiscountOffer (Billing Library 7.0+) - Update llms.txt with new type documentation - Add release blog post Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
5a8563d to
5120122
Compare
Summary
Related
OpenIAP Versions
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation
Chores