Skip to content

fix(apple): accept apple purchase props #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyochan merged 1 commit into from
Jun 15, 2026
Merged

fix(apple): accept apple purchase props #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/apple/Sources/OpenIapModule.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1615,14 +1615,14 @@ public final class OpenIapModule: NSObject, OpenIapModuleProtocol {

/// Resolves iOS purchase props from request params.
/// Returns either RequestPurchaseIosProps or RequestSubscriptionIosProps based on request type.
private func resolveIOSPurchaseProps(from params: RequestPurchaseProps) throws -> any IosPropsProtocol {
func resolveIOSPurchaseProps(from params: RequestPurchaseProps) throws -> any IosPropsProtocol {
switch params.request {
case let .purchase(platforms):
if let ios = platforms.ios {
if let ios = platforms.apple ?? platforms.ios {
return ios
}
case let .subscription(platforms):
if let ios = platforms.ios {
if let ios = platforms.apple ?? platforms.ios {
return ios
}
}
Expand Down
41 changes: 41 additions & 0 deletions packages/apple/Tests/OpenIapTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,47 @@ final class OpenIapTests: XCTestCase {
XCTAssertNil(decoded.advancedCommerceData)
}

@available(iOS 15.0, macOS 14.0, tvOS 16.0, watchOS 8.0, *)
func testResolvePurchasePropsUsesAppleAlias() throws {
let props = RequestPurchaseProps(
request: .purchase(RequestPurchasePropsByPlatforms(
apple: RequestPurchaseIosProps(sku: "dev.hyo.apple"),
ios: RequestPurchaseIosProps(sku: "dev.hyo.legacy")
))
)

let resolved = try OpenIapModule.shared.resolveIOSPurchaseProps(from: props)

XCTAssertEqual(resolved.sku, "dev.hyo.apple")
}

@available(iOS 15.0, macOS 14.0, tvOS 16.0, watchOS 8.0, *)
func testResolvePurchasePropsFallsBackToLegacyIosAlias() throws {
let props = RequestPurchaseProps(
request: .purchase(RequestPurchasePropsByPlatforms(
ios: RequestPurchaseIosProps(sku: "dev.hyo.legacy")
))
)

let resolved = try OpenIapModule.shared.resolveIOSPurchaseProps(from: props)

XCTAssertEqual(resolved.sku, "dev.hyo.legacy")
}

@available(iOS 15.0, macOS 14.0, tvOS 16.0, watchOS 8.0, *)
func testResolveSubscriptionPropsUsesAppleAlias() throws {
let props = RequestPurchaseProps(
request: .subscription(RequestSubscriptionPropsByPlatforms(
apple: RequestSubscriptionIosProps(sku: "dev.hyo.sub.apple"),
ios: RequestSubscriptionIosProps(sku: "dev.hyo.sub.legacy")
))
)

let resolved = try OpenIapModule.shared.resolveIOSPurchaseProps(from: props)

XCTAssertEqual(resolved.sku, "dev.hyo.sub.apple")
}

func testAdvancedCommerceDataJSONSerialization() throws {
let props = RequestPurchaseIosProps(
advancedCommerceData: "promo_code_abc",
Expand Down
2 changes: 1 addition & 1 deletion packages/docs/src/generated/version-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"godotPackageVersion": "2.3.1",
"kmpPackageVersion": "2.3.1",
"mauiPackageId": "OpenIap.Maui",
"mauiPackageVersion": "1.1.1",
"mauiPackageVersion": "1.1.2",
"googleCompileSdk": "35",
"googleMinSdk": "23",
"googlePlayBillingVersion": "8.3.0",
Expand Down