fix(google): correct SubscriptionProductReplacementParams Replacement…#72
Conversation
…Mode constants Fix incorrect replacementModeConstant mapping in applySubscriptionProductReplacementParams(). The code was using values from the legacy SubscriptionUpdateParams.ReplacementMode API instead of the new SubscriptionProductReplacementParams.ReplacementMode API (Billing 8.1.0+). Affected modes: - CHARGE_FULL_PRICE: 5 → 4 - DEFERRED: 6 → 5 - KEEP_EXISTING: 7 → 6 Also: - Add SubscriptionReplacementModeTest.kt with comprehensive test coverage - Update subscription-upgrade-downgrade docs with correct API values table - Add v1.3.27 release notes Closes #71 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @hyochan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical bug in the Google Play Billing integration where the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughCorrects Android subscription replacement-mode constant mapping in OpenIapModule, adds a mapping extension and tests verifying legacy vs. Billing Library 8.1.0+ constants and JSON (de)serialization, and updates docs and release notes to show tabular replacement-mode mappings and explanatory notes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a critical bug in the Google Play Billing integration, where incorrect constants were used for subscription replacement modes. The changes are well-executed, including necessary updates to documentation and the addition of a comprehensive test suite to cover the new logic. My review includes one suggestion to refactor the test implementation to avoid duplicating production logic, which will improve long-term maintainability.
hyochan
added
⌚️ regression
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@packages/docs/src/pages/docs/features/subscription-upgrade-downgrade.tsx`:
- Around line 1085-1138: Wrap the existing table element in a container div with
CSS to prevent overflow (e.g., class or inline style setting overflow: 'hidden'
and width: '100%'), and add fixed layout and word-wrapping to the table cells by
applying tableLayout: 'fixed' to the <table> and overflowWrap/wordBreak (e.g.,
overflowWrap: 'break-word' and wordBreak: 'break-word') to <th> and <td> styles;
update the table rendering in subscription-upgrade-downgrade.tsx (the <table>
and its <th>/<td>) to include these styles so the replacement-mode table cannot
overflow on narrow viewports.
In
`@packages/google/openiap/src/test/java/dev/hyo/openiap/SubscriptionReplacementModeTest.kt`:
- Around line 143-165: Replace the Kotlin built-in assert(...) calls in the
tests with JUnit assertions so the checks always run; specifically change the
two assertions that verify legacyValue != newValue to use
org.junit.jupiter.api.Assertions.assertNotEquals(legacyValue, newValue,
"message") for the tests that call
getSubscriptionProductReplacementModeConstant(SubscriptionReplacementModeAndroid.ChargeFullPrice)
and
getSubscriptionProductReplacementModeConstant(SubscriptionReplacementModeAndroid.Deferred),
preserving the existing failure messages.
🧹 Nitpick comments (2)
packages/docs/src/pages/docs/features/subscription-upgrade-downgrade.tsx (1)
1338-1341: Clarify which API the numeric DEFERRED value applies to in examples.Line 1340 lists both legacy and 8.1.0+ constants, but the code examples below still use
replacementMode: 6. Consider a short note thatrequestPurchase()uses legacySubscriptionUpdateParamsvalues, while per‑product replacements usesubscriptionProductReplacementParams(DEFERRED = 5).Suggested clarification
<ol> <li> <strong>Use DEFERRED replacement mode</strong> (Legacy API: 6, 8.1.0+ API: 5) </li> <li>No immediate charge to the user</li> <li>User keeps premium access until current period ends</li> <li>Basic subscription starts at next billing date</li> </ol> + <p style={{ fontSize: '0.875rem', color: 'var(--text-secondary)' }}> + Note: <code>replacementMode</code> in <code>requestPurchase()</code> uses legacy + <code>SubscriptionUpdateParams</code> values (DEFERRED = 6). For Billing 8.1.0+ + per‑product replacement, use <code>subscriptionProductReplacementParams</code> with + DEFERRED = 5. + </p>packages/docs/src/pages/docs/updates/notes.tsx (1)
28-69: Keep the new note table from overflowing small screens.The table can exceed the container width on narrow devices; wrap it in an
overflow-hiddencontainer and add fixed layout/word breaking.Proposed fix
- <table style={{ width: '100%', borderCollapse: 'collapse', marginTop: '0.5rem', marginBottom: '0.5rem' }}> + <div className="overflow-hidden"> + <table + style={{ + width: '100%', + borderCollapse: 'collapse', + marginTop: '0.5rem', + marginBottom: '0.5rem', + tableLayout: 'fixed', + wordBreak: 'break-word', + }} + > ... - </table> + </table> + </div>As per coding guidelines, ensure tables never overflow their containers.
- Wrap replacement mode table in scrollable container for narrow screens - Replace Kotlin assert() with JUnit assertNotEquals() for reliable test execution Co-Authored-By: Claude <noreply@anthropic.com>
- Create SubscriptionReplacementModeAndroidExt.kt with toReplacementModeConstant() - Update OpenIapModule.kt to use the shared extension function - Simplify test file by removing duplicated mapping logic This ensures tests verify actual production logic instead of a reimplementation. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/docs/src/pages/docs/features/subscription-upgrade-downgrade.tsx`:
- Line 1350: Several downgrade examples hardcode the DEFERRED replacement mode
value as 6 even though the note at "Use DEFERRED replacement mode" states
DEFERRED = 6 for Legacy API and DEFERRED = 5 for 8.1.0+; update each example
that currently uses the literal 6 to either (a) use 5 when the example targets
8.1.0+ or (b) keep 6 but add an inline annotation (e.g., "// Legacy API" or "//
8.1.0+") next to the hardcoded value so readers know which API version the
example is for; search for occurrences of the literal "6" in the
subscription-upgrade-downgrade examples that mention DEFERRED and add the
appropriate value or comment consistently.
♻️ Duplicate comments (2)
packages/google/openiap/src/test/java/dev/hyo/openiap/SubscriptionReplacementModeTest.kt (1)
32-68: Avoid duplicating the mapping logic in tests.
Consider extracting the enum→constant mapping into a shared helper used by production and tests so the suite doesn’t re‑implement the logic and drift over time.packages/docs/src/pages/docs/features/subscription-upgrade-downgrade.tsx (1)
1085-1148: Prevent replacement‑mode table overflow on narrow screens.
The wrapper currently allows horizontal scrolling and the table lacks fixed layout/word breaking, so long content can still exceed the container. Consider switching to an overflow‑hidden wrapper and fixed layout with word breaking so the table always fits within the doc column.Suggested tweak
- <div style={{ overflowX: 'auto' }}> + <div className="overflow-hidden"> <table style={{ width: '100%', borderCollapse: 'collapse', marginTop: '0.5rem', marginBottom: '0.5rem', fontSize: '0.875rem', + tableLayout: 'fixed', + wordBreak: 'break-word', }} >As per coding guidelines, tables should not overflow their containers.
🧹 Nitpick comments (1)
packages/docs/src/pages/docs/features/subscription-upgrade-downgrade.tsx (1)
1368-1370: Add a reference or version scope for the “empty purchase list” behavior.
Line 1368–1370 is a strong behavioral claim; consider citing the Billing docs or noting the BillingClient version(s) you validated so readers can trust when it applies.
…sion Add "(Legacy API value)" annotation to all code examples that use DEFERRED = 6 to clarify this is for the legacy SubscriptionUpdateParams API, not the new SubscriptionProductReplacementParams API (8.1.0+) where DEFERRED = 5. Co-Authored-By: Claude <noreply@anthropic.com>
1 participant
Summary
Fix incorrect
replacementModeConstantmapping inapplySubscriptionProductReplacementParams(). The code was using values from the legacySubscriptionUpdateParams.ReplacementModeAPI instead of the newSubscriptionProductReplacementParams.ReplacementModeAPI (Billing 8.1.0+).Affected modes:
CHARGE_FULL_PRICEDEFERREDKEEP_EXISTINGChanges
OpenIapModule.kt- Fix ReplacementMode constantsSubscriptionReplacementModeTest.kt- Add comprehensive test coveragesubscription-upgrade-downgrade.tsx- Update docs with Legacy API vs 8.1.0+ API values tablenotes.tsx- Add v1.3.27 release notesReferences
Closes #71
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation
Tests
✏️ Tip: You can customize this high-level summary in your review settings.