[refactor] don't call scrollTo in native mode #391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already scroll to the current cell using scrollIntoView() when focusing it. No need to do the job twice.
On the contrary, when using the virtual scroll, we need to operate in two steps:
isScrolling === false), we use scrollIntoView to scroll horizontallyWe cannot use scrollIntoView for point 1. because the new scrollTop would not be aligned with the computed state.