Repository navigation
fix(metrics): count a failed receive as a transport error only - #169
Merged
Merged
Conversation
A failed receive reads no record. The loop counted it in archive_errors_total and the console's records_error total. Deleting a source left its topic subscribed, so the console showed record errors where no record existed. scalo already counts the failure in transport_recv_errors_total by class. The e2e test deletes the topic while the archiver runs and checks that archive_errors_total stays at zero. It fails without the fix.
scalo 2.14.29 skips the Kafka ecosystem's internal topics in discovery, so a scale-profile archiver no longer archives Strimzi Cruise Control's topics. It also unsubscribes from the deleted last topic when discovery finds no topic. The helm library pin moves to 2.14.29.
catinspace-au
marked this pull request as ready for review
November 10, 2026 17:55
The schema's default topic_exclude now lists the five Kafka-ecosystem internal topic patterns scalo 2.14.29 adds.
librdkafka only learns a topic was deleted at its next metadata refresh, five minutes by default. The test's 45 second wait for a failed receive passed or timed out by chance. It now sets a one-second refresh, so the failed receive comes within the wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed receive reads no record. The loop counted it in archive_errors_total and the console's records_error total. Deleting a source left its topic subscribed, so the console showed record errors where no record existed. scalo already counts the failure in transport_recv_errors_total by class.
The e2e test deletes the topic while the archiver runs and checks that archive_errors_total stays at zero. It fails without the fix.