Repository navigation
fix(compose): read alert destinations from the engine's secrets backend - #363
Draft
catinspace-au wants to merge 1 commit into
Draft
catinspace-au wants to merge 1 commit into
catinspace-au wants to merge 1 commit into
Conversation
The engine stores each alert destination's URL at alert-destinations/<name> in its secrets backend. The hunt runner reads it through scalo.secrets. The runner mounts only that directory of the engine's file backend read-only and sets DFE_ENGINE_SECRETS_PATH to match. Remove the old mount of the engine's alert-destinations directory: it holds only metadata. The engine creates the directory at startup. The runner waits for a healthy engine, so the subpath exists before the mount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine stores each alert destination's URL at alert-destinations/ in its secrets backend. The hunt runner reads it through scalo.secrets. The runner mounts only that directory of the engine's file backend read-only and sets DFE_ENGINE_SECRETS_PATH to match.
Remove the old mount of the engine's alert-destinations directory: it holds only metadata.
The engine creates the directory at startup. The runner waits for a healthy engine, so the subpath exists before the mount.