Repository navigation
fix(schemas): serve the column vocabulary - #1127
Merged
Merged
Conversation
The console kept its own copies of the primitives, use cases and override types, and they drifted from dfe-schemas. It offered retired use cases and had no map or vector. - GET /api/v1/schemas/vocabulary serves primitives, use cases and override types from the pinned dfe-schemas registry, with labels and the names each use case replaced. - GET /api/v1/system/defaults carries the retention maximum beside the value. - The external pipeline header table uses the header's @source expressions. It no longer shows @timestamp as the source for _timestamp. Labels and override options live in dfe-schemas types.yaml. Until the pin moves to a release that has them, labels use the names and no override types are offered.
The form needs to offer `cardinality: low` before a column can use it. The vocabulary dropped the retired `lowcardinality` attribute without its replacement. The vocabulary has `cardinality` values, default and labels. It also lists what each retired attribute reads as (`lowcardinality` is `low`). The vocabulary reads from the `cardinality` block of dfe-schemas types.yaml. Labels come from its `labels` map when present.
The vocabulary route reads these registry fields through pydantic from_attributes, which leaves no attribute access in the source for vulture to see.
0.2.29 has the type vocabulary labels and override options. The vocabulary route serves labels and 29 override types instead of names alone.
The default header version is no longer a constant. The external pipeline header table reads the profile at the version dfe-schemas marks current.
The source columns response carried attributes but no cardinality, so the console could not show a saved column as `low`. The response now reports the declared cardinality. A column with the retired `lowcardinality` attribute reads as `low`.
The cardinality helper returns the Cardinality literal the response field declares, which ty needs. THIRD-PARTY-NOTICES lists dfe-schemas at the version the lock pins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The console's own lists of primitives, use cases and override types drifted from dfe-schemas. The schema form offered retired use cases and had no map or vector.
cardinalityhas values, a default, labels and a retired attribute mapping for each value. A form can offerlowand read a storedlowcardinalityaslow.ttl_days.maximum, so the form stops hard coding 365 when the engine takes 36500.timestamp | now().An override type with arguments has a template such as
Decimal({precision},{scale})and typed parameters. A form can build the text without knowing the type.Pinned to dfe-schemas 0.2.29 for labels and override options. Cardinality labels come with dfe-schemas #114. Until then the engine serves the capitalised value.