Repository navigation
fix(security): contain profile paths under their schemas root - #1134
Merged
Merged
Conversation
The API can write a profile ref (header.type). The resolver joins it onto a schemas directory. It refused `..` and rebuilt the ref from non-empty segments. It followed symlinks, so a link inside the tree could read any file the pod could access. Every join in _resolve_profile_yaml_path resolves the candidate and its root with os.path.realpath. Candidates outside the root are refused. That covers the explicit profiles dir, DFE_ENGINE_SCHEMAS_DIR, the schemas root and the fallback. CodeQL's py/path-injection query models realpath plus a startswith check as a barrier. This resolves code-scanning alert 70.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API can write a profile ref (header.type). The resolver joins it onto a schemas directory. It refused
..and rebuilt the ref from non-empty segments. It followed symlinks, so a link inside the tree could read any file the pod could access.Every join in _resolve_profile_yaml_path resolves the candidate and its root with os.path.realpath. Candidates outside the root are refused. That covers the explicit profiles dir, DFE_ENGINE_SCHEMAS_DIR, the schemas root and the fallback.
CodeQL's py/path-injection query models realpath plus a startswith check as a barrier. This resolves code-scanning alert 70.