Repository navigation
fix(metrics): report pressure and processed counts - #285
Open
kazmosahebi wants to merge 2 commits into
Open
kazmosahebi wants to merge 2 commits into
kazmosahebi wants to merge 2 commits into
Conversation
The `buffer_depth` component measured the guard's used bytes against `buffer.memory_limit`, which defaults to 0 and was floored to 1. Any buffered byte read as full, so an idle fetcher reported a scaling pressure of 40. It now measures the used share of the guard's own limit, so an idle fetcher reads under 1.
Nothing incremented `records_processed_total`, so the Components card showed 0 processed beside the delivered rate. Each batch now adds the rows enrichment did not refuse once the whole batch is through. An aborted flush counts nothing, so its re-fetch counts each row once, as received does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buffer_depthcomponent measured the guard's used bytes againstbuffer.memory_limit, which defaults to 0 and was floored to 1, so any buffered byte read as full. It now measures the used share of the guard's own limit.records_processed_total, so the Components card showed 0 processed beside the delivered rate. Each batch now adds the rows enrichment did not refuse once the whole batch is through. An aborted flush counts nothing, so its re-fetch counts each row once, as received does.On a dfe-docker stack the pressure reads 0.60 to 0.73, and CloudTrail reads 78 received, processed and delivered.
hyperi-ci checkpasses on three feature builds: the default,jemallocalone anddb-clickhousewithdb-mongodbandfile-tail.