Repository navigation
fix(api): read the engine timeout from DFE_ENGINE_TIMEOUT_MS - #204
Merged
Merged
Conversation
engine-session, org-connection and query-export now read one config value instead of each holding ENGINE_TIMEOUT_MS = 5000. DFE_ENGINE_TIMEOUT_MS sets the timeout in whole milliseconds above zero. The default is 5000. An invalid set value stops the API starting. All changes are under dfe/. No upstream files change. The branch is based on fix/org-connection-engine-names because both edit org-connection.ts.
catinspace-au
force-pushed
the
fix/h16-engine-timeout
branch
from
November 11, 2026 07:14
96387f1 to
151ff60
Compare
catinspace-au
marked this pull request as ready for review
November 11, 2026 08:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
engine-session, org-connection and query-export each declared ENGINE_TIMEOUT_MS = 5000. They now read DFE_ENGINE_TIMEOUT_MS from dfe/config.ts.
Done when: config.test.ts tests parsing, each of the three call sites tests the configured value on AbortSignal.timeout, and eslint and tsc pass.
The config, org-connection, engine-session and query-export suites pass on the rebased branch (154 tests).