Repository navigation
fix(loader): dfe-clickhouse 0.1.11, risk scoring and discovery from config - #327
Merged
Merged
Conversation
0.1.11 sets input_format_try_infer_dates=0 and input_format_try_infer_datetimes=0 on every HTTP insert into JSON columns. A date-like string at a _json path now stays String instead of mixing Date and String rows at that path.
Risk scoring kept its country lists, weights, signal scores and level bands in match arms. Unknown presets silently fell back to global. Those settings now live in enrichment.risk_scoring. The five shipped presets form the default presets map. Deployments can override any value. Each preset entry replaces only the shipped preset of that name. Startup and reload reject unknown presets and name the valid ones. They also reject scores over 100 and level bands out of order. Auto-discovery subscribed to _(land|load)$ regardless of routing.topic_suffixes. The discovery include now uses the escaped suffixes. Loading fails for an empty suffix, or no suffix while discovery is on. Remove the coercion section and three ClickHouse type helpers. Only their own tests used them. The loader defaults in dfe-engine still write a coercion section, which the loader now ignores.
Clippy refuses assert! on is_empty in the risk config override test, which failed the Quality job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes dfe-clickhouse 0.1.11, which stops the HTTP insert turning a date-like string at a _json path into a Date.
Risk scoring's country lists, weights, signal scores and level bands move out of match arms into enrichment.risk_scoring config. The five shipped presets are the defaults. A deployment can override any value. Unknown presets fail at load with an error listing the valid names.
Unknown presets previously fell back to global silently.
Auto-discovery builds its include from escaped routing.topic_suffixes instead of a fixed _(land|load)$. Empty suffixes are refused. Discovery also refuses missing suffixes when on.
The coercion section and unread type helpers are deleted. The dfe-engine loader defaults still write a coercion section, which the loader ignores. Removing coercion from those defaults is a rollout change.
Done when CI Quality and Test are green. The release is cut separately, so there's no release trailer.