Repository navigation
fix(tests): read mTLS alerts until the server closes - #251
Merged
Merged
Conversation
Under TLS 1.3 the server refuses a missing or untrusted client certificate after the client has finished its side of the handshake. The no-certificate and other-CA cases closed s_client one second after it started. If the receiver took longer, the cases failed without reading its alert. Under a 25% CPU quota, the old test failed 8 of 34 cases with no alert in the output. Those cases now read until the server closes the connection or the existing 10 second timeout ends. When the verifier allows unauthenticated clients, the five HTTP-family listeners still fail the no-certificate case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under TLS 1.3 the server refuses a missing or untrusted client certificate after the client has finished its side of the handshake. The no-certificate and other-CA cases closed s_client one second after it started. If the receiver took longer, the cases failed without reading its alert. Under a 25% CPU quota, the old test failed 8 of 34 cases with no alert in the output.
Those cases now read until the server closes the connection or the existing 10 second timeout ends. When the verifier allows unauthenticated clients, the five HTTP-family listeners still fail the no-certificate case.