Repository navigation
fix(console): read the column vocabulary from the engine - #707
Merged
Merged
Conversation
The schema form had local lists of primitives, use cases, attributes and override types. The derived schema picker had another use case list. These lists offered retired use cases and missed map, vector and key_search. - Primitives, use cases, attributes and override types come from GET /api/v1/schemas/vocabulary. - Override inputs use engine-declared parameters instead of switching on the type name. - A failed system defaults fetch shows the error. The client no longer supplies its own retention and header version. - The retention form takes its maximum from the engine: 36500 days instead of the hard-coded 365.
A column made in the console could never be `cardinality: low`, so it had no LowCardinality wrap and exact_match fell back to a bloom filter. - A Cardinality select sits beside Attributes and writes the column's `cardinality`. It shows the engine's default until a value is picked. - A column with the retired `lowcardinality` attribute shows as Cardinality Low. The attribute is dropped because the engine rejects conflicting cardinality declarations. - The type, index and attribute selects show Loading... instead of No data while the vocabulary loads. - Index use cases are filtered by the column's type. Both the schema form and the derived schema picker show the label with the question as the hint. - Edit on the system defaults card reports a defaults loading failure instead of doing nothing.
- CSV import keeps a `cardinality` column. The v1 low cardinality types map to cardinality low. - The source columns tab, review step and schema detail table show a Cardinality column. - Changing a column's type clears an index use case the new type cannot take. - A stored retired use case name shows as its replacement. - The system defaults card shows Loading... and the edit form's error notice on failure. It previously showed zero values and an empty engine. - The Cardinality column is wide enough for Unknown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema form had separate lists of primitives, use cases, attributes and override types. The derived schema picker had another use case list. They offered retired use cases and missed map, vector and key_search.
cardinality. A column with the retiredlowcardinalityattribute shows as Low.Needs the dfe-engine PR and dfe-schemas 0.2.28 or later.
similarity_search is not in the column picker. It needs a dimension count, and the picker has nowhere to type one.
The generated engine types add only this route and
maximum. The sync job brings the rest of the engine's spec.