Repository navigation
fix(sources): read engine limits from its OpenAPI - #711
Merged
Merged
Conversation
The source form duplicated three engine limits. - The engine publishes the match nesting depth, reserved operators and credential reference prefixes in its OpenAPI. generate:limits generates packages/dfe-engine-types/limits/index.ts from them. - MATCH_NESTING_LIMIT, MATCH_OPERATORS and CREDENTIAL_REFERENCE_PREFIXES come from that file. The form keeps its exports. - engineLimits.test.ts checks the generated file against the spec. specs/openapi.json has the three engine schemas that hold those keys until the whole file is synced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source form reads three engine limits from the engine's OpenAPI instead of keeping its own copy.
specs/openapi.json has three schemas from that PR pending a full file sync: SourceMatch, SourceExternal and SourceTransform. The operator union in types/index.d.ts moves not_equals after ends_with.
Done when vitest passes (57 files, 412 tests) and tsc and eslint are clean. The source form is untested in Playwright.