Do not warn if setsockopt fails due to ECONNRESET #2494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case a client disconnects early, setting socket options
(nodelay/keepalive) fails and causes warnings. These warnings
have little value, given that modifying options on an already
broken connection is basically a noop.
This can happen in case of bad connectivity/congestion, but
also by design like in haproxy, which "uses RST to close the
health check as it free’s[sic!] resources on haproxy and the
backend server immediately".
Due to the above we encounter quite some log spam:
WARN tonic::transport::server::incoming:error trying to
set TCP_NODELAY: Connection reset by peer (os error 54)
WARN tonic::transport::server::incoming:error trying to
set TCP_KEEPALIVE: Connection reset by peer (os error 54)
(This is on FreeBSD, hence "os error 54" (ECONNRESET)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In case a client disconnects early, setting socket options (nodelay/keepalive) fails and causes warnings. These warnings have little value, given that modifying options on an already broken connection is basically a noop.
This can happen in case of bad connectivity/congestion, but also by design like in haproxy, which "uses RST to close the health check as it free’s[sic!] resources on haproxy and the backend server immediately".
Due to the above we encounter quite some log spam:
(This is on FreeBSD, hence "os error 54" (ECONNRESET)).
Solution
Do not warn in case setting socket options fails due to the connection being reset by the client.