Skip to content

Runtime errors don't seem to cause tests to fail #216

Description

@CaptainIRS

For example in https://github.com/hyperledger/caliper-benchmarks/runs/7194966698?check_suite_focus=true#step:5:3026

2022.07.05-11:18:19.096 error [caliper] [worker-message-handler] 	Error while handling "prepare" message for Worker (14245): ReferenceError: bytes is not defined
    at Object.module.exports.addBatchAssets (/home/runner/work/caliper-benchmarks/caliper-benchmarks/benchmarks/api/fabric/workloads/helper.js:69:29)
    at RangeQueryAssetWorkload.initializeWorkloadModule (/home/runner/work/caliper-benchmarks/caliper-benchmarks/benchmarks/api/fabric/workloads/rich-query-asset.js:64:26)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async CaliperWorker.prepareTest (/home/runner/work/caliper-benchmarks/caliper-benchmarks/node_modules/@hyperledger/caliper-core/lib/worker/caliper-worker.js:161:13)
    at async WorkerMessageHandler._handlePrepareMessage (/home/runner/work/caliper-benchmarks/caliper-benchmarks/node_modules/@hyperledger/caliper-core/lib/worker/worker-message-handler.js:210:13)
    at async ProcessMessenger.<anonymous> (/home/runner/work/caliper-benchmarks/caliper-benchmarks/node_modules/@hyperledger/caliper-core/lib/worker/worker-message-handler.js:89:13)

It seems to be a bug related to https://github.com/hyperledger/caliper-benchmarks/blame/main/benchmarks/api/fabric/workloads/helper.js#L7, however the tests are shown to have passed in the GitHub Actions workflow.

This issue is different from issue #211 as this issue deals with potential bugs in the caliper-benchmarks codebase.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingbuild

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions