-
Notifications
You must be signed in to change notification settings - Fork 64
updating autoReload feature #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aceppaluni
wants to merge
6
commits into
hyperledger:main
Choose a base branch
from
aceppaluni:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−0
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2020a87
updating autoReload feature
aceppaluni cce6c0b
fix(config): correctly place autoReload under config and update init …
aceppaluni d2ea100
fix: update stack manager config reference
aceppaluni 1277eb7
fix: remove single line comment
aceppaluni 405d864
chore: remove temporary autoreload debug file
aceppaluni 929cb50
Fix TestMockConfigWithAutoReload: correct YAML structure and nil check
aceppaluni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| package stacks | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "github.com/hyperledger/firefly-cli/pkg/types" | ||
| "gopkg.in/yaml.v3" | ||
| ) | ||
|
|
||
| func main() { | ||
| cfg := &types.FireflyConfig{ | ||
| Config: &types.CoreConfig{}, | ||
| } | ||
|
|
||
| cfg.Config.AutoReload = true | ||
|
|
||
| out, err := yaml.Marshal(cfg) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| fmt.Println(string(out)) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| package stacks | ||
| import ( | ||
| "os" | ||
| "path/filepath" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "gopkg.in/yaml.v3" | ||
|
|
||
| "github.com/hyperledger/firefly-cli/pkg/types" | ||
| ) | ||
|
|
||
| func TestMockConfigWithAutoReload(t *testing.T) { | ||
| tmpDir := os.TempDir() | ||
| configDir := filepath.Join(tmpDir, "config") | ||
|
|
||
| // Ensure the config directory exists | ||
| err := os.MkdirAll(configDir, 0755) | ||
| assert.NoError(t, err) | ||
|
|
||
| configPath := filepath.Join(configDir, "firefly_core_member1.yml") | ||
|
|
||
| // Write mock config YAML with autoReload true | ||
| configYAML := []byte(` | ||
| autoReload: true | ||
| `) | ||
|
|
||
| err = os.WriteFile(configPath, configYAML, 0644) | ||
| assert.NoError(t, err) | ||
|
|
||
| // Read the file back in | ||
| content, err := os.ReadFile(configPath) | ||
| assert.NoError(t, err) | ||
|
|
||
| var config types.FireflyConfig | ||
| err = yaml.Unmarshal(content, &config) | ||
| assert.NoError(t, err) | ||
|
|
||
| // Check that AutoReload is true as expected | ||
| assert.True(t, config.Config.AutoReload) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.