audit: classify 10 FFI unsafe findings as legitimate (PA001/PA007)#35
Merged
Conversation
panic-attack assail flags 10 UnsafeCode/UnsafeFFI Critical/High findings under src/api/zig/ — all at the Zig→C ABI boundary. Adds: - audits/assail-classifications.a2ml (10 entries, classification=legitimate-ffi) - audits/audit-ffi-2026-05-26.md Refs hyperpolymath/panic-attack#32. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🔍 Hypatia Security ScanFindings: 74 issues detected
View findings[
{
"reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Nickel file missing SPDX-License-Identifier header (1 occurrences, CWE-1104)",
"type": "ncl_missing_spdx",
"file": "/home/runner/work/aerie/aerie/configs/config.ncl",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "unwrap() without prior check -- DoS via panic (1 occurrences, CWE-754)",
"type": "unwrap_without_check",
"file": "/home/runner/work/aerie/aerie/src/api/rust/src/redis_client.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (3 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/smokeping_client.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (3 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/hyperglass_client.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (3 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/main.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @bitCast reinterprets bits without type checking (1 occurrences, CWE-704)",
"type": "zig_bit_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/proof.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (2 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/librespeed_client.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (5 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/verisim_client.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"line": 220,
"reason": "Secret found: Generic API key",
"type": "secret_detected",
"file": "/home/runner/work/aerie/aerie/src/api/zig/main.zig",
"action": "revoke_rotate_and_purge",
"rule_module": "security_errors",
"severity": "critical"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
- Replace examples/SafeDOMExample.res with the canonical examples/SafeDOMExample.affine (per gitbot-fleet#208 and the banned-ReScript anti-pattern policy).
🔍 Hypatia Security ScanFindings: 74 issues detected
View findings[
{
"reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Nickel file missing SPDX-License-Identifier header (1 occurrences, CWE-1104)",
"type": "ncl_missing_spdx",
"file": "/home/runner/work/aerie/aerie/configs/config.ncl",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "unwrap() without prior check -- DoS via panic (1 occurrences, CWE-754)",
"type": "unwrap_without_check",
"file": "/home/runner/work/aerie/aerie/src/api/rust/src/redis_client.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (3 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/smokeping_client.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (3 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/hyperglass_client.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (3 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/main.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @bitCast reinterprets bits without type checking (1 occurrences, CWE-704)",
"type": "zig_bit_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/proof.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (2 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/librespeed_client.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (5 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/verisim_client.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"line": 220,
"reason": "Secret found: Generic API key",
"type": "secret_detected",
"file": "/home/runner/work/aerie/aerie/src/api/zig/main.zig",
"action": "revoke_rotate_and_purge",
"rule_module": "security_errors",
"severity": "critical"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
|
🔍 Hypatia Security ScanFindings: 78 issues detected
View findings[
{
"reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Nickel file missing SPDX-License-Identifier header (1 occurrences, CWE-1104)",
"type": "ncl_missing_spdx",
"file": "/home/runner/work/aerie/aerie/configs/config.ncl",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "unwrap() without prior check -- DoS via panic (1 occurrences, CWE-754)",
"type": "unwrap_without_check",
"file": "/home/runner/work/aerie/aerie/src/api/rust/src/redis_client.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (3 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/smokeping_client.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (3 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/hyperglass_client.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (3 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/main.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @bitCast reinterprets bits without type checking (1 occurrences, CWE-704)",
"type": "zig_bit_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/proof.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (2 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/librespeed_client.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Zig @ptrCast performs unchecked pointer type conversion (5 occurrences, CWE-704)",
"type": "zig_ptr_cast",
"file": "/home/runner/work/aerie/aerie/src/api/zig/verisim_client.zig",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"line": 220,
"reason": "Secret found: Generic API key",
"type": "secret_detected",
"file": "/home/runner/work/aerie/aerie/src/api/zig/main.zig",
"action": "revoke_rotate_and_purge",
"rule_module": "security_errors",
"severity": "critical"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
panic-attack assail reports 10 UnsafeCode (PA001) + UnsafeFFI (PA007) Critical/High findings under
src/api/zig/(main.zig, hyperglass_client.zig) — all at the Zig→C ABI boundary.What changes
Same pattern as svalinn#11, proven#67, gossamer#54, docudactyl#20, proven-servers#11.
Refs hyperpolymath/panic-attack#32.
🤖 Generated with Claude Code