Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #86

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: db9caeab-3b0f-4023-b161-114c11392a7b

📥 Commits

Reviewing files that changed from the base of the PR and between a618d3e and 1679185.

📒 Files selected for processing (1)
  • .github/workflows/governance.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (6)
  • GitHub Check: scan / rust-secrets
  • GitHub Check: scan / gitleaks
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: scan / shell-secrets
  • GitHub Check: Analyze (actions)
  • GitHub Check: lint-workflows
🔇 Additional comments (1)
.github/workflows/governance.yml (1)

35-38: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Corrected governance workflow permissions to ensure required workflow operations run reliably.

Walkthrough

The governance workflow now declares its permissions block at the job level. The block grants actions: read, contents: read, and security-events: write.

Changes

Governance workflow

Layer / File(s) Summary
Correct job-level permissions
.github/workflows/governance.yml
The governance job moves its permissions block out of the uses section and applies the required permission values at job level.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: repairing invalid YAML caused by incorrect permissions block indentation.
Description check ✅ Passed The description directly explains the YAML indentation issue, the preserved permissions, and the validation performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow gate
Permissions now sit in the right place
Actions and contents can be read
Security events can be spread
The governance path is clear and neat

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit efd616d into main Sep 21, 2026
10 of 11 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant