fix(ci): hoist secrets to job env in mirror-reusable; refresh example SHAs#416
Merged
Merged
Conversation
… SHAs
mirror-reusable.yml (two real bugs):
- Remove duplicate `if:` key on the "Mirror to GitLab" step.
- The `secrets` context is not valid in step-level `if:` (it is an
"Unrecognized named-value: 'secrets'" startup failure). Hoist each
forge secret to a job-level `env:` block and gate every step `if:` on
`env.<FORGE>_KEY` instead of `secrets.<FORGE>_SSH_KEY`, matching the
already-correct `mirror-radicle` pattern. Applies to all six forge
jobs (gitlab, bitbucket, codeberg, sourcehut, disroot, gitea).
Behaviour identical; only the reference site moves. actionlint clean.
{elixir,deno,rust,changelog}-*-reusable.yml:
- Refresh the stale copy-paste example SHA in the header comments
(861b5e9 -> 4762ba6, current main HEAD) so new adopters copy a
current pin. Comment-only.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task A — mirror-reusable.yml (two real bugs)
Bug 1 — duplicate
if:key. The "Mirror to GitLab" step hadif: ${{ secrets.GITLAB_SSH_KEY != '' }}twice (withcontinue-on-error: truebetween). Removed the duplicate so the step has exactly oneif:.Bug 2 —
secretscontext in stepif:. Thesecretscontext is not valid in step-levelif:— it is anUnrecognized named-value: 'secrets'startup failure. Hoisted each forge secret to a job-levelenv:block and changed every stepif:to gate onenv.<FORGE>_KEY, matching the already-correctmirror-radiclejob. Applied to all six forge jobs: gitlab, bitbucket, codeberg, sourcehut, disroot, gitea. Behaviour is identical; only the reference site moved.actionlintclean.Task B — refresh stale example SHAs
The header copy-paste usage examples in
{elixir-ci,deno-ci,rust-ci,changelog}-reusable.ymlpinned@861b5e9…(stale, ~70 commits behind, beyond the staleness window). Refreshed to currentmainHEAD4762ba66441de05bccb36e074ba3d2202219126a. Comment-only.Validation
actionlintclean on all 5 files.secrets.*remains in any stepif:.🤖 Generated with Claude Code