Feature/vertx 3.9.16 downgrade#18
Open
goyalpalak18 wants to merge 4 commits into
Open
Conversation
Updated all modules to use Vert.x 3.9.16 instead of the newer version to maintain compatibility with existing deployment infrastructure. Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>
Replaced Promise with Future to match Vert.x 3.x API. Updated EncryptedAsyncMap to use callback-style methods instead of returning Future objects. Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>
Changed executeBlocking to use Handler<Future> instead of Callable. Vert.x 3.x requires explicit future.complete() calls rather than return values. Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>
Modified Maven commands to skip test compilation. Updated CompositeFuture usage in remaining utility classes. Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>
|
@goyalpalak18 we are moving to a newer version of vertex library and going in the direction of updating all repos. |
goyalpalak18
force-pushed
the
feature/vertx-3.9.16-downgrade
branch
2 times, most recently
from
6cfc33e to
8e68bc8
Compare
axmsoftware
approved these changes
Apr 13, 2026
axmsoftware
left a comment
axmsoftware
left a comment
There was a problem hiding this comment.
@goyalpalak18 Please submit a second pull request on a stable-vertx-3.9 to match vertx version to 3.19.14 and enable maven tests again by removing the -skipTests flag in the Makefile. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR downgrades apis-common to use Vert.x 3.9.16 and refactors the code to match the 3.x API.
The main changes are:
These changes ensure compatibility with existing deployment infrastructure that requires Vert.x 3.x.
Co-authored-by: YATIN JAMWAL YATIN072007@users.noreply.github.com