Bump apis-common version 3.0.0 → 3.4.1 to match apis-bom#24
Closed
PRAteek-singHWY wants to merge 1 commit into
Closed
Bump apis-common version 3.0.0 → 3.4.1 to match apis-bom#24PRAteek-singHWY wants to merge 1 commit into
PRAteek-singHWY wants to merge 1 commit into
Conversation
apis-common imports apis-bom as a BOM via <version>${project.version}</version>,
so apis-common's own version must match the currently-published apis-bom
version. apis-bom was bumped to 3.4.1; apis-common was still at 3.0.0,
which means Maven tried to resolve apis-bom:pom:3.0.0 (no longer published)
and failed the build of every downstream module.
Bringing apis-common to 3.4.1 also re-enables junit version resolution
through the BOM (apis-bom 3.4.1 pins junit 4.13.2 in dependencyManagement),
which clears the secondary 'dependencies.dependency.version for junit:junit
is missing' error.
Signed-off-by: PRAteek-singHWY <prateek23022004@gmail.com>
Member
|
Hello @PRAteek-singHWY, thank you for your contribution as it's already mentioned in this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
apis-common/pom.xmlimports the project BOM as:${project.version}resolves to whatever this module's own<version>says - currently3.0.0. The siblinghyphae/apis-bomis on3.4.1, andapis-bom:pom:3.0.0is no longer published to Maven Central, so the BOM import is unresolvable from a clean clone.This surfaces in CI as:
(See hyphae/APIS#101 - the failing run that prompted this.)
The second error is a side-effect:
apis-bom3.4.1 pinsjunitat 4.13.2 in its<dependencyManagement>, so once the BOM resolves, the version-lessjunitdependency in this pom inherits its version correctly.Change
One line in
pom.xml:Nothing else touched - no new dependencies, no behavior change, no rename, no build-script edits.
Verification
apis-bom3.4.1 installs cleanly (mvn installfrom a fresh clone ofhyphae/apis-bom).mvn installinapis-commonresolves the BOM, picks upjunit4.13.2 transitively, and builds.make build-apis-bom build-apis-commonfromhyphae/APIS.Follow-ups (out of scope for this PR)
The downstream modules (
apis-main,apis-ccc,apis-log,apis-web) likely have the same3.0.0 → 3.4.1drift and will need parallel bumps before the umbrellamake buildis fully green again. Happy to open those as separate PRs.