Conversation
Fixed tagging errors in YamlReaderWriter
|
thanks for the patch! it looks pretty straightforward, I will get around to it soon. |
|
I'll award the gun.io bounty as soon as infinity0 says it's working. Thanks Tim! |
|
@infinity0 - any updates on this? |
|
Sorry, I totally forgot about this. Yes, this looks good, but please fix the inconsistent spacing you've added to build.xml. I can do this by myself when I get some free time, but in that case I will be forced to overwrite your commits (rather than the "automatic merge" option github gives me) and you will need to hard-reset your repo to the new HEAD. (If you don't understand what I just said you need to learn more git.) |
|
Hi, did you get around to this? I've forgotten the context of this request and the master repo has since moved on from this. |
|
I did not. I will find the repo for you if i still have it on github, Sent from my wireless phone.
|
|
I take it this is still worthwhile in principle? This no longer merges cleanly, and SnakeYAML is at version 1.14 now. |
|
On Oct 25, 2014 11:37 AM, "Steve Dougherty" notifications@github.com
I think it would be worthwhile, but I don't know enough about the code to
|
|
@infinity0 this looks useful, but currently it doesn’t merge. Can you take it up again so we can merge and release it? |
|
@infinity0 could you have another look? (I am now in a position where I can release soon) |
|
Hey, I'm sorry but my attention is elsewhere these days and I won't be able to complete this. Feel free to take it over completely. |
|
@ArneBab Latest release is 1.26. Can the PR be upgraded to the latest release? I'm up for it. |
|
Sounds good. |
|
There's work already done at: https://github.com/redwerk/plugin-Library/tree/v37-dw-rw3 This PR should be closed. |
|
Can you open another one for the new version? |
Do you mean to implement the upgrade on another PR? Would not that cause a merge conflict the redwerk's work? |
|
I mean to just close this in favor of #15 which pulls in all the changes aggregated at redwerk. |
No description provided.