Skip to content

fix: clean up render processes without ps - #204

Open
521Peter wants to merge 1 commit into
hypit-ai:mainfrom
521Peter:fix/capture-cleanup-without-ps
Open

521Peter wants to merge 1 commit into
hypit-ai:mainfrom
521Peter:fix/capture-cleanup-without-ps

Conversation

@521Peter

Copy link
Copy Markdown

Summary

  • replace the POSIX-wide ps scan with parent-scoped pgrep -P traversal
  • probe process liveness with process.kill(pid, 0) and stop waiting at the cleanup deadline
  • preserve a completed render result if best-effort cleanup itself fails
  • add regression coverage for a host where ps is denied

Fixes #199

Verification

  • node --import tsx --test packages/provider-hyperframes-local/test/capture-process.test.ts (3 tests passed)
  • pnpm check (passed)
  • git diff --check (passed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

killRenderTree depends on ps, so a host that denies ps fails every Build after the render already succeeded

1 participant