docs: fix SNN-PC attribution to Lee 2024 - #49
Open
electron-rare wants to merge 1 commit into
Open
Conversation
The BioFieldWML Phase 2 sources cited a non-existent reference "Palacios, arXiv:2409.05386" for SNN predictive coding. Verification found this wrong twice: 2409.05386 is the N'dri et al. 2024 survey (not SNN-PC), and no author "Palacios" exists. Corrected all docstrings, specs, plan, CHANGELOG and README to the real reference (Lee, Dora, Mejias, Bohte & Pennartz, Frontiers in Comp. Neuroscience 2024, DOI 10.3389/fncom.2024.1338280); the survey is retained, correctly attributed, as a disambiguation note only.
There was a problem hiding this comment.
Pull request overview
This PR corrects the BioFieldWML Phase 2 attribution from the nonexistent Palacios/arXiv reference to Lee et al. 2024, while preserving the survey arXiv ID only as a disambiguation note.
Changes:
- Updates code docstrings/comments and unit-test references to cite Lee et al. 2024.
- Updates README, CHANGELOG, substrate overview, specs, and plan documentation.
- Adds clarification that
arXiv:2409.05386is a survey, not the SNN-PC mechanism source.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
track_w/spiking_kiki_bio_client.py |
Updates adapter docstring attribution to Lee et al. |
track_w/bio_field_wml.py |
Updates BioFieldWML Phase 2 documentation/comments attribution. |
tests/unit/test_bio_wml_pc.py |
Updates test module reference citation. |
README.md |
Updates BioFieldWML plan reference in the project summary table. |
docs/superpowers/specs/2026-05-21-spike-attention-moe-design.md |
Updates SNN-PC compatibility citation. |
docs/superpowers/specs/2026-05-21-biofield-spikingkiki-coupling-design.md |
Updates coupling design citation and examples. |
docs/superpowers/plans/2026-05-19-bio-substrate-wml.md |
Replaces Ref B-3 citation and adds arXiv disambiguation note. |
docs/substrate-paradigms.md |
Updates BioField PC-VMP provenance citation. |
CHANGELOG.md |
Updates biological substrate integration attribution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| **Note on arXiv:2409.05386.** | ||
| That arXiv ID corresponds to a *survey* paper (N'dri, Gebhardt, | ||
| Teulière, Zeldenrust, Rao, Triesch, Ororbia & al., *"Predictive Coding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
Les sources BioFieldWML Phase 2 (PR #24) citaient une référence inexistante « Palacios, arXiv:2409.05386 » pour le predictive-coding spiking. Une vérification deep-research (citations contrôlées) a montré deux erreurs :
arXiv:2409.05386= le survey N'dri et al. 2024, pas un papier SNN-PC.Correction
Toutes les occurrences (docstrings
bio_field_wml.py/spiking_kiki_bio_client.py, test, specs, plan, CHANGELOG, README) pointent désormais vers la vraie référence SNN-PC : Lee, Dora, Mejias, Bohte & Pennartz, Predictive coding with spiking neurons and feedforward gist signaling, Frontiers in Comp. Neuroscience 2024, DOI 10.3389/fncom.2024.1338280. Le survey N'dri (2409.05386) est conservé, correctement attribué, en note de désambiguïsation.Changements de texte uniquement (commentaires/doc/citations), aucune logique modifiée.
grep palacios= 0.🤖 Generated with Claude Code