[barrettruth]

Hi, ran into this when setting up a laptop on freebsd.

no matter the time i set the display failure factor too, a wrong login would flash always for an extremely short amount of time.

This should fix it, ensuring only a key press removes the error and that the initial "enter" release event when the first wrong password is types does NOT remove the error box.

[barrettruth]

@vaxerski hi, this project is still in active development right?

This is a significant behavior malfunction with quite a simple fix - sorry for the prod :)

[gucci-mane2006]

Tested this on Nobara 44/Hyprland 0.56.2 by building hyprlock v0.9.6 with PR #1084’s commit (858ef8c) cherry-picked

On the current release I was also experiencing this issue after configuring pam.d/hyprlock to remove the delay that happens when an incorrect password is entered. Normally the pam auth has a 2-ish second delay after a wrong password is entered - the failure display disappearing on a key release still persists with default pam auth, but isn't noticeable as input handling seems to pause during the delay as users typically aren't interacting with the keyboard. Removing the delay makes it much more apparent. One thing I noticed is that the fail state also clears on any key press event, including non-text keys that don't change the input (e.g. Alt, Caps Lock, Enter, etc.). Not sure if this is intended behavior and/or if the maintainers are aware of this but I felt it worth mentioning.

Anyway, my build successfully ran and I confirmed this PR fixes the issue for my system. Hope to see this fix next release 😺