Repository navigation
core: fix compose result over-read in handleKeySym - #1086
Open
martintrojer wants to merge 1 commit into
Open
martintrojer wants to merge 1 commit into
martintrojer wants to merge 1 commit into
Conversation
martintrojer
marked this pull request as ready for review
October 28, 2026 10:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xkb_compose_state_get_utf8returns the full length even if the buffer is too small. With a 16 byte stack buffer, a compose result of 16+ bytes makesstd::string{buf, len-1}read past it.Needs a user
~/.XCompose; the longest stock entry here is 6 bytes. ASan build on headless sway: 17 bytes givesstack-buffer-overflow READ of size 17, 36 bytes reads 36. At exactly 16 a NUL ends up in the password.Fix asks for the length first and sizes the string to it. 15/16/17/36 bytes and a 21 byte UTF-8 result all come out complete with no ASan report.