Conversation
gyengus
requested review from
bucherarnold,
czenczl,
lacipadar,
martin-nagy,
petrenyi-mark and
vasizs
as code owners
rombow
reviewed
Jun 10, 2024
rombow
approved these changes
Jun 11, 2024
czenczl
previously approved these changes
Jun 11, 2024
bucherarnold
previously approved these changes
Oct 16, 2024
Open
vasizs
reviewed
Nov 18, 2024
| * | ||
| * @param status | ||
| * sample status | ||
| * @param status sample status |
speter555
reviewed
Nov 18, 2024
|
|
||
| protected ISampleRestJsonClient getRestClient() { | ||
| return RestClientBuilder.newBuilder() | ||
| .baseUri(URI.create(ConfigProvider.getConfig().getValue("sampler.service.sample.base.uri", String.class))) |
There was a problem hiding this comment.
Ha már cdi-t tudunk tesztben használni, én ezt injectelném, sokkal szebb mint példa.
speter555
reviewed
Nov 18, 2024
| ); | ||
| } | ||
|
|
||
| protected SampleResponse getResponse() throws BaseException { |
There was a problem hiding this comment.
miért kell protected? És kicsit nekem zavaró (ez lehet egyéni), de egy metódusba bújtatva minden az nem adja ki a open-closed principle-t. Tudom hogy példa, de akkor már legyen jobban bővíthető. Ha pl request lenne akkor azt végig kéne mindenhol csurgatni. Miközben csak a rest híváshoz kell a restClient metódusába.
czenczl
approved these changes
Nov 27, 2024
vasizs
approved these changes
Dec 2, 2024
vasizs
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.