feat(core): flag published docs linking only to unpublished content#137
Merged
Merged
Conversation
Relationship checks are now status-aware. When a published document's relationship rule is satisfied by count but every matched related record is a draft, the live page links to nothing live at runtime. Emit CMS-RELATIONSHIP-UNPUBLISHED (warning) naming an example draft target. Stays silent when at least one matched target is published, and still reports CMS-RELATIONSHIP-MISSING when there are no matches at all, so the existing count behavior is unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes relationship checks status-aware. When a published document's relationship rule is satisfied by count, but every matched related record is a draft, the live page links to nothing live at runtime. cms-lab now emits
CMS-RELATIONSHIP-UNPUBLISHED(warning) naming an example draft target.CMS-RELATIONSHIP-MISSINGstill fires when there are no matches at all, so the existing count behavior is unchanged (additive).Why
"Unpublished linked documents" is one of the original cms-lab failure modes and was top of the feedback wishlist ("unpublished relational content"). It is a classic editorial bug: the related content exists in the CMS so the rule looks satisfied, but it was never published, so the published page is broken at runtime. This is the status-aware direction from #71.
How verified
CMS-RELATIONSHIP-UNPUBLISHED; one published target -> silent; no targets ->CMS-RELATIONSHIP-MISSING(not UNPUBLISHED).pnpm verifygreen (206 tests).Refs #71, improvements relationship work.