Fix comparison page route and revert incomplete coverage gate#138
Merged
Conversation
Two regressions reached main because their CI was red at merge: - The comparison page linked to /docs/quick-start, which is a markdown doc but not a site route, so Next typedRoutes failed the site build. Point the link at /docs (the docs home that carries the quick start). Regenerated the docs search index to include the comparison page. - The coverage gate wired @vitest/coverage-v8 into verify but the dependency was never installed, so verify failed outside CI's plain test step. Revert verify and the test:coverage script to the prior known-good chain. Coverage thresholds can be re-added later with the dependency committed. verify passes locally.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two regressions reached
mainbecause their CI was red at merge time. This repairs the release/build path:/docs/quick-start, which exists as markdown but not as a site route, so NexttypedRoutesfailed the site build. Link now points at/docs. Regenerated the docs search index to include the comparison page.@vitest/coverage-v8inverifywithout the dependency installed, soverifyfailed outside CI's plainteststep. Revertedverifyand removed thetest:coveragescript. Coverage thresholds can be re-added later with the dependency committed (tracked separately).How verified
pnpm verifypasses locally (site build now succeeds; the only Prettier warnings are untracked local-only files not present in CI).pnpm typecheck,pnpm build,pnpm site:buildpass.