Add a bundle-size budget with size-limit#140
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Adds size-limit budgets for the published bundles and wires the check into verify after the build. Limits sit above current brotli sizes with headroom (core 3.5 kB vs 2.47 kB, react 9 kB vs 6.89 kB, server 1 kB vs 394 B), so accidental size regressions fail the build. Closes #136
i-afaqrashid
force-pushed
the
issue-136-size-limit
branch
from
b8649b0 to
e2960f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
size-limitbudgets for the three published bundles and wirespnpm sizeintoverifyafter the build, so size regressions fail the build. Dependency and lockfile are committed together.How verified
pnpm sizepasses: core 2.47 kB (limit 3.5), react 6.89 kB (limit 9), react/server 394 B (limit 1 kB) — minified + brotli.Closes #136