Add a logarithmic frequency scale to SpectrumCanvas#142
Merged
Conversation
Adds a scale prop ("log" | "linear", default "log"). On the log scale the
canvas reads the full FFT and aggregates bins into log-spaced bars (peak
per band), so the whole audible range shows instead of only the lowest
bins. Linear keeps the previous one-bin-per-bar behavior. Includes a pure
readSpectrumBarValue helper with unit tests and documents the prop.
Closes #142
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Adds unit tests for readSpectrumBarValue (null/empty, linear one-bin read, log peak aggregation that surfaces high bins, in-bounds mapping) and a docs/api.md bullet for the SpectrumCanvas scale prop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
scaleprop toSpectrumCanvas("log" | "linear", default"log"). The log scale aggregates the full FFT into log-spaced bars (peak per band) so the whole audible range is visible, instead of only the lowest ~1 kHz.scale="linear"keeps the previous one-bin-per-bar behavior.How verified
readSpectrumBarValuehelper with unit tests (null/empty, linear one-bin read, log peak aggregation that surfaces high bins, in-bounds mapping).scaledocumented indocs/api.md.pnpm verifypasses locally.Closes #141