Repository navigation
Conversation
Several Techem MVT rows had version and type swapped relative to wmbusmeters (`mvt = TCH,<version>,<type>`), so MK-Radio 3/4/3a water, Compact V heat, Vario 451 heat and TSD2 smoke frames never matched their driver and fell through to the generic OMS walker, which printed nonsense (e.g. "Heat (volumetric) VolFlow: 1194806222389 m^3/h"). - Align all Techem MVT rows with wmbusmeters drivers/src/*.xmq. - Add MK-Radio water version 0x52 (field captures, MK-Radio 3 layout). - Title water meters warm/cold; show billing dates for MK-Radio 4. - MK-Radio 4a, Vario 451 MID and Vario 411 are OMS DIF/VIF frames: route them to the generic walker. - Fix Vario 451 MJ->kWh conversion (raw / 3.6, was raw * 250 / 9). - Decode TSD2 smoke status (OK / SMOKE / DEFECT) and billing date. - Drop reversed duplicate FHKV rows. - Host tests with wmbusmeters vectors and field captures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several Techem MVT rows have version and type swapped compared with wmbusmeters, where
mvt = TCH,<version>,<type>matches theWmbusMVT {manuf, version, medium}order. As a result MK-Radio 3/4/3a water, Compact V heat, Vario 451 heat and TSD2 smoke frames never reach their driver. They fall through to the generic OMS walker, which prints nonsense, e.g. a warm-water meter shown as:Changes
mkradio3.xmqmkradio4.xmqmkradio4a.xmqmkradio3a.xmqcompact5.xmqvario451.xmqvario451mid.xmq,vario411.xmqtsd2.xmqfhkvdataiii/iv.xmqOther fixes:
raw × 250 / 9; it israw / 3.6(matches the wmbusmeters vario451 test: 3642 / 2729 kWh, previously 364222 / 272944).-).tsd2.xmq.Captured frames (meter IDs anonymised)
v0x52 warm water (T=0x62):
→
Now 3.1 m3 / Period 0.1 / Last 3.0 / Reset 2026-09-30 / Read 2026-11-03v0x52 cold water (T=0x72):
→
Now 24.2 m3 / Period 2.0 / Last 22.2v0x95 warm water (T=0x62):
→
Now 76.0 m3 / Reset 2026-09-30 / Read 2026-11-03Checklist
drivers/src/{mkradio3,mkradio3a,mkradio4,mkradio4a,compact5,vario451,vario451mid,vario411,tsd2,fhkvdataiii,fhkvdataiv}.xmqufbt, official firmware 1.5.1 / API 88.2, no warnings)tests/test_techem_water.candtests/test_techem_other.cuse the wmbusmeters test vectors;make -C tests checkpassesHeat meters and TSD2 were not available on hardware; they are verified only against the wmbusmeters test vectors.
🤖 Generated with Claude Code