Skip to content

Green CI: ArangoDB integration tests + doctests need a live server #1

Description

@thorwhalen

Context

CI has been red. The immediate cause (a from py2store.util import lazyprop
import in arangodol/__init__.py, which broke module collection) is now fixed —
lazyprop is imported from dol.util. But the package still cannot reach a
fully green CI because its tests and doctests require a live ArangoDB server.

What still needs doing (pick one path)

Path A — run the tests for real (preferred):

  • Add an ArangoDB service container to the CI workflow (Actions services: with
    the official arangodb image on :8529, root/root).
  • Update the stale doctest imports in arangodol/__init__.py:
    • from py2store.persisters.arangodb_w_pyarango import ArangoDbPersister → from arangodol import ArangoDbPersister
    • from py2store.stores.arangodb_store import ArangoDbTupleKeyStore → from arangodol import ArangoDbTupleKeyStore
  • Point testpaths at arangodol (currently declares a non-existent tests/).

Path B — skip DB-dependent examples in CI:

  • Mark the ArangoDbPersister / ArangoDbTupleKeyStore doctests # doctest: +SKIP
    (they connect to 127.0.0.1:8529).
  • Gate arangodol/tests/ behind a live-server check (skip when unreachable).

Also

  • testpaths declares ['tests'] which does not exist on disk → rootdir fallback.

Filed while running the fleet wads health rollout.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions