Repository navigation
ops: refuse same-key writes from other threads during an operation; batch failure notes (#5) - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5.
Tests: threaded layer refused and nothing written; other keys / after the window allowed; failed batch note. Doctest for the threaded case in `routing.py`.
Review: fresh Opus adversarial review confirmed one blocking defect (Redirect dataclass compared by equality, which reads whole stores under the registry lock and could remove another thread's entry), plus the batch note skipping subclassed leaves and an over-sure wording. All fixed with tests; docs now also name the different-leaf-object limit. Fixes are small and local; not re-reviewed.
🤖 Generated with Claude Code