docs: preserve the METAR hand-ingress anti-example in cw.ingress - #37
Merged
Merged
Conversation
The deletion sweep (#29) removes the argh block in i2mint/examples' metar_acquisition.py. Its acceptance criteria require the block be preserved first: it is the fleet's clearest motivating example for why string-to-object conversion belongs to the framework as a declared seam rather than to hand-written glue at the dispatch call. Refs #29 Claude-Session: https://claude.ai/code/session_01K6LB3AwUmKDxaFNZ2NqPGr
thorwhalen
added a commit
to i2mint/examples
that referenced
this pull request
Sep 4, 2026
Part of the fleet-wide argh removal (i2mint/cw#29). Neither block was reachable: this repo has no packaging metadata at all, so argh was never declared and never installed alongside these scripts. Both functions remain importable and callable; only the argh entry points go. metar_acquisition.py's block was additionally broken on its own terms — it built a coercing wrapper (`.split(',')`, `int()`) and then dispatched the *original*, uncoerced function, so the coercion never ran; its `except ImportError` fallback called the rebound name with no arguments. It is preserved verbatim as the motivating anti-example in cw's `cw/ingress.py` (i2mint/cw#37) before removal here, per #29's acceptance criteria. Refs i2mint/cw#29 Claude-Session: https://claude.ai/code/session_01K6LB3AwUmKDxaFNZ2NqPGr
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for the deletion sweep (#29).
#29's acceptance criteria say the argh block in
i2mint/examplesexamples/airport_weather/metar_acquisition.py:80-98must be preserved in cw's docsbefore the file is touched. This does that, in
cw/ingress.py's module docstring —the module whose whole reason for existing is the problem that block gets wrong.
The block is quoted verbatim in a literal (non-doctest) code block, followed by a short
reading of what it does: it defines a shadowing wrapper that coerces
airport_idswith.split(',')andhours_before_nowwithint(), and then dispatches_acquire_metar_data— the original, uncoerced function. The wrapper is never called.Nothing raises. The
except ImportErrorfallback is broken too.No code change.
952 passed, 2 skipped(unchanged), and--doctest-modules cw/ingress.pyis green — the added block is indented-literal, not a doctest.
Refs #29