Repository navigation
WIP snapshot (git stash, 2026-07-11): ongoing work with paths — preserved before branch cleanup - #102
Closed
thorwhalen wants to merge 1 commit into
Closed
thorwhalen wants to merge 1 commit into
thorwhalen wants to merge 1 commit into
Conversation
…mint/dol ... on going work with paths (preserved stash)
Member
Author
|
Closing to preserve the ref (refs/pull/102/head) while cleaning up a long-idle stashed-WIP remote branch. See PR body for the full assessment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: unattended assessment — a
git stashsnapshot, not a reviewed feature branchThis branch's own commit title is
WIP on master: 07f7885 ... on going work with paths (preserved stash)— it's agit stash pushthat got pushed to origin as an archival snapshot, not authored as a PR. It has no open PR, no linked issue, and pre-dates the currentmasterby roughly two months (dol/paths.pywas 1143-2265 lines then vs. now).What it contains
Mostly mechanical
black-style reformatting ofdol/paths.py(single→double quotes, trailing-comma wrapping) mixed with a few genuinely new pieces:split_if_str,separate_keys_with_separator,path_filter, and_return_none_if_none_input— this last one has a malformed docstring (the closing paren of an example block appears with no opening""", so the function body follows what reads as broken/truncated text). This is not close to landable as-is.Why I'm not landing it
dolhas many dependents across the fleet — a behavior change here needs verification against all of them, and this diff isn't even internally consistent (the_return_none_if_none_inputdocstring is broken). It also predates ~2 months of independent evolution ondol/paths.py.What would make it clearly landable or droppable
Someone with context on "ongoing work with paths" reviews whether
path_filter/separate_keys_with_separator/split_if_strare still wanted given how farpaths.pyhas moved since, fixes the broken docstring, and reformats to match current style rather than 2-months-staleblackoutput.Closing immediately after opening — this PR exists only so the branch tip is recoverable from
refs/pull/<N>/headafter the remote branch is deleted (git-hygiene cleanup of long-idle unlanded branches; dol#stash-cleanup).