WIP snapshot (git stash, 2026-07-11): paths.py lint-fix follow-on — preserved before branch cleanup (covers stash/20260711-2 too) - #103
Closed
thorwhalen wants to merge 1 commit into
Closed
thorwhalen wants to merge 1 commit into
thorwhalen wants to merge 1 commit into
Conversation
… call is valid only within a class (preserved stash)
Member
Author
|
Closing to preserve the ref (refs/pull/103/head) while cleaning up long-idle stashed-WIP remote branches (this covers stash/20260711-1 and, by content, the byte-identical stash/20260711-2). See PR body for the full assessment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: unattended assessment — a
git stashsnapshot, not a reviewed feature branchThis branch's own commit title is
WIP on master: b0e3a86 fix: Pylance lint... (preserved stash)— agit stash pushpushed to origin as an archival snapshot. No open PR, no linked issue, ~2 months stale against currentmaster.What it contains
Reformatting of
dol/paths.pyplus one new helper,_return_none_if_none_input— which has a malformed docstring: an example block's closing paren appears with no matching opening""", so the text reads as broken/truncated mid-docstring, followed directly by the real function body. Not close to landable as-is.Note:
origin/stash/20260711-2is a byte-identical duplicate of this branch'sdol/paths.py(confirmed via direct diff) — its content is fully preserved by this PR, so it does not get a separate preservation PR.Why I'm not landing it
dolhas many dependents fleet-wide; this diff is not internally consistent (broken docstring) and predates significant independent evolution ofdol/paths.py.What would make it clearly landable or droppable
Someone reviews whether
_return_none_if_none_inputis still wanted, fixes the docstring, and reconciles against currentpaths.py.Closing immediately after opening — this PR exists only so the branch tip is recoverable from
refs/pull/<N>/headafter the remote branches are deleted (git-hygiene cleanup of long-idle unlanded branches).