Repository navigation
feat: scan_items/scan_values accept wrapped stores (#6) - #10
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6. For a dol-wrapped store (any non-dynamodol Mapping)
scan_items/scan_valuesnow returniter(store.items())/iter(store.values())(batched, honouring the wrapper's scope and codecs); a bare reader keeps the single-scan path; non-mappings raise TypeError at the call.test_scan_refuses_wrapped_storeis replaced by tests of the new behaviour (mocks only).Adversarial Opus review: no defect introduced; one pre-existing gap (subclass overriding
__iter__/__getitem__takes the raw path) filed as a follow-up issue.🤖 Generated with Claude Code