Repository navigation
scan_items/scan_values honour a reader subclass overriding __iter__/__getitem__ (#9) - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9. The single-scan fast path is taken only when
type(store)does not override__iter__/__getitem__outside the dynamodol package (MRO owner check); otherwisescan_items/scan_valuesdelegate to.items()/.values(), which honour the override. dynamodol's own subclasses (prefix, partition, query readers, persisters) keep the fast path. Mocks only.Adversarial review (fresh Opus, ~35 experiments): verdict merge. Applied its suggestions: tolerate
__module__ = None, and the docstring says only those two overrides are detected. Not changed (judged acceptable): a subclass definingitems = scan_itemsplus an override now recurses loudly instead of silently returning unmapped values; overrides of_scan_records/items()are not detected.🤖 Generated with Claude Code