You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Three unrelated cleanup items found during the 2026-07-30 wave-0 rollout pass. All were deliberately left for maintainer sign-off rather than applied unprompted, since each removes something.
1. Over-declared dependencies
[project] dependencies declares py2store and openpyxl, but neither is imported by any module in focal/. Re-verified: py2store appears only inside README example fences.
The only real third-party imports are dol (focal/__init__.py, focal/extension_store.py) plus numpy/pandas, which are lazily imported inside with suppress(ModuleNotFoundError) guards and so are optional by design.
Suggested: drop py2store and openpyxl from dependencies. If openpyxl is wanted for the xlsx path, move it to [project.optional-dependencies] rather than a hard runtime dep. Check the README examples still make sense afterwards.
2. 66 legacy generated Sphinx files still tracked on the default branch
git ls-files docs | wc -l → 66, despite .gitignore line 1 being docs/*. These are the old generated docs tree; Pages now serves from gh-pages root, published by the CI epythet docs job.
Suggested: git rm -r --cached docs and commit, so the ignore rule takes effect and the generated tree stops being versioned. Confirm https://i2mint.github.io/focal/ still serves afterwards (it is published from gh-pages, so it should be unaffected).
3. [tool.wads.ci.metrics] points at a file that does not exist
.github/umpyre-config.ymldoes not exist in this repo, and there is no code-metrics branch. The gate is switched on with nothing behind it — a degraded no-op.
Suggested: set enabled = false, or add the config if code metrics are actually wanted. (Same leftover umpyre wiring was found and disabled in i2mint/git2py.)
Context worth knowing before touching tests here
This repo's testpaths was fixed in the same rollout pass: it had been ["tests"], which silently excluded the real suite (focal/tests/test_extension_store.py) and all module doctests — collection went 1 → 7 items. So the current test coverage is newly-effective; do not be surprised by it. Fleet-level context: i2mint/wads#56.
Items 1 and 3 landed (PR #7, merged): dropped unused py2store dependency, moved openpyxl to a new excel optional-dependencies group, disabled the dead [tool.wads.ci.metrics] gate.
Item 2 (66 stale tracked docs/ files) deliberately not touched — largest "removes something" item, explicitly left for your sign-off. Plan if/when you want it done: git rm -r --cached docs && git commit, then confirm https://i2mint.github.io/focal/ still serves (it publishes from gh-pages, independent of the tracked docs/ tree, so it should be unaffected) before pushing.
Activity
chore: drop unused deps, move openpyxl to an extra, disable dead metr…
thorwhalen commentedon Sep 22, 2026
Items 1 and 3 landed (PR #7, merged): dropped unused
py2storedependency, movedopenpyxlto a newexceloptional-dependencies group, disabled the dead[tool.wads.ci.metrics]gate.Item 2 (66 stale tracked
docs/files) deliberately not touched — largest "removes something" item, explicitly left for your sign-off. Plan if/when you want it done:git rm -r --cached docs && git commit, then confirm https://i2mint.github.io/focal/ still serves (it publishes fromgh-pages, independent of the trackeddocs/tree, so it should be unaffected) before pushing.Untrack stale docs/ tree; make README examples real; pin dol>=0.3.71 (#4