test: absolute-key store test is Windows-aware - #88
Merged
Merged
Conversation
On Windows a drive-letter key (store\C:\...) is not a valid path, so the write raises OSError (as it did before #87) instead of landing inside the root; assert that, and that the file the key names is untouched. #87's Windows job failed on this and was missed because the Windows job does not fail the workflow. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #87 (#85). The post-merge Windows job failed on
test_absolute_key_is_written_inside_the_root: on Windows,store\C:\...is not a valid path, so the write raisesOSError(WinError 123). This is the same as before #87, and it never touches the file the key names. The test now asserts exactly that on Windows. The POSIX branch is unchanged.Test-only change; no library code touched. I missed this before merging #87 because the Windows job fails without failing the workflow run. I read the run-level conclusion, not the per-job results.
🤖 Generated with Claude Code